This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Make sure we poll authority event stream until all events are processed #5608
Merged
Conversation
bkchr
added
A0-please_review
mxinden
approved these changes
Apr 11, 2020
Contributor
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Thanks a bunch for catching this!
I will follow up on this next week, removing the mix of Poll and try operator to make returns easier to review.
mxinden
added a commit
to paritytech/polkadot
that referenced
this pull request
Apr 11, 2020
Fixing authority discovery leak.
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.